Skip to content

Add debug logging to synology_dsm#42806

Closed
mib1185 wants to merge 2 commits into
home-assistant:devfrom
mib1185:synology-dsm_debug-logging
Closed

Add debug logging to synology_dsm#42806
mib1185 wants to merge 2 commits into
home-assistant:devfrom
mib1185:synology-dsm_debug-logging

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Nov 3, 2020

Proposed change

Add debug logging output for better troubleshooting in case of issues.
Need rebase as soon as #42697 and #42777 are merged.
Opened as draft to collect, if existing, additional suggestions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@mib1185 mib1185 force-pushed the synology-dsm_debug-logging branch from e724fb8 to 6dbc16e Compare November 3, 2020 22:27
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jan 26, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 28, 2021

This PR has been in a draft and running stale without activity since November.
I'll go ahead and close this PR for now. Feel free to re-open the PR again when ready to start working on it. Contributions are always appreciated 👍

@frenck frenck closed this Jan 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 29, 2021
@mib1185 mib1185 deleted the synology-dsm_debug-logging branch May 11, 2021 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants